fix(copilot): honor preset command template overrides#3592
Open
faqehanoor wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Copilot command generation to honor preset command overrides.
Changes:
- Resolves Copilot command templates through
PresetResolver. - Adds fallback and override regression tests.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/copilot/__init__.py |
Adds preset-aware command resolution. |
tests/integrations/test_integration_copilot.py |
Tests fallback and preset override behavior. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Medium
Comment on lines
+374
to
+376
| resolved_template = preset_resolver.resolve( | ||
| src_file.stem, template_type="command" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Summary
Fixes #2761 by updating the Copilot integration to resolve command templates through the existing preset-aware
PresetResolver.Previously, Copilot always used the bundled shared command templates, causing preset-provided command template overrides (such as
specify.md) to be ignored. With this change, Copilot now honors preset overrides while preserving the existing fallback behavior when no override is available.What changed
PresetResolver.resolve(..., template_type="command")Testing